websocket: avoid WebSocketClosedError double/nested exception #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking the exception that was being handled when another exception
was raised is a new feature in Python-3, causing this:
Traceback (most recent call last):
File "/...-packages/tornado/websocket.py", line 1104, in wrapper
await fut
tornado.iostream.StreamClosedError: Stream is closed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/...-packages/tornado/websocket.py", line 1106, in wrapper
raise WebSocketClosedError()
tornado.websocket.WebSocketClosedError
This can be selectively avoided using the new Python-3 syntax:
raise WebSocketClosedException from None
ploxiln
force-pushed
the
websocket_closed_from_none
branch
from
11f3eef
to
7566672
Compare
|
As I said in #2824 (comment), I'm generally not a fan of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking the exception that was being handled when another exception
was raised is a new feature in Python-3, causing this:
This can be selectively avoided using the new Python-3 syntax:
I just find the double-exception to be more ugly than it has to be, a matter of taste I guess, so I humbly offer this easy change in case you find it acceptable.